[email protected] wrote:
> >I see. Does it work if you just remove the :sh from the definition of
> >MANIFESTS? The definition of ALL_MANIFESTS is supposed to work as it is,
> >but I can see how trying to execute its value on the next line would give
> >you crud.
>
> Yes, I was able to adjust this as follows:
>
> ALL_MANIFESTS:sh = \
> cd manifests; \
> print *.p5m | sed -e 's/:/\\:/g'; \
> exit 0
> $(PUBLISHALL)MANIFESTS = $(ALL_MANIFESTS)
>
> I also adjusted the definitions of CHANGESET, ARCH and REV in a similar
> manner since it simplies their definition a bit as well.
... except I think that would drastically reduce the performance. What's
nice about
ARCH.cmd = uname -p
ARCH = $(ARCH.cmd:sh)
is that "uname -p" gets run once -- when $(ARCH) is defined. With
ARCH:sh = uname -p
it gets run every time $(ARCH) is referenced. And it's referenced a fair
amount. So I think I like the way you had it before better, even if it's a
bit longer.
> https://cr.opensolaris.org/action/browse/pkg/comay/7168702-et-al-2/webrev/
>
> >And while you're changing i386_DEFINES and sparc_DEFINES, you might as well
> >update line 92 (ARCH_DEFINES) to use the same whitespace pattern as
> >everything else.
>
> Done. In addition, I folded two long lines (definitions of BUILDID.cmd
> and PKGVERS_BRANCH) that I noticed exceeded the line length while
> examining the diff.
Okay.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
