On 05/29/12 21:40, Tim Foster wrote:
hi there,
I've got a change here that allows SMF manifests which contain
'require_all' dependencies that specify SMF services as their FMRIs to
get converted to 'require-any' pkg(5) dependencies via pkgdepend(1) in
cases where several files deliver instances of that service.
(yes, I know that sounds odd - an SMF "require_all" somehow translating
to a "require-any" pkg(5) dependency.
In SMF, a "require_all" dependency specifying a service FMRI can be
satisfied by at least one instance of that service, so pkg(5) needs to
ensure that a package delivering at least one of these instances is
installed)
https://cr.opensolaris.org/action/browse/pkg/timf/pkgdep-smf-req-any
src/modules/flavor/base.py
line 88: s/raise/raised/
line 97: If this error will be seen by the user, it should be more
descriptive.
line 238: s/non-None/not None/
src/modules/flavor/smf_manifest.py:
line 284: this should be moved inside the exception case, as its
pointless to assign a value and then immediately reassign on
line 286
line 302: the comment seems confusing given line 309
I mainly did a sanity check; someone more familiar with the dependency
code should look over this too.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
