On 05/31/12 15:21, Tim Foster wrote:
On 06/ 1/12 10:05 AM, Shawn Walker wrote:
On 05/29/12 21:40, Tim Foster wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/pkgdep-smf-req-any
Thanks for taking a look,
src/modules/flavor/base.py
line 88: s/raise/raised/
line 97: If this error will be seen by the user, it should be more
descriptive.
line 238: s/non-None/not None/
Fixed those - the error won't be seen by a user, since it indicates a
programming error error in creating the PublishingDependency object (I
considered an assert, but thought an exception would be better)
src/modules/flavor/smf_manifest.py:
line 284: this should be moved inside the exception case, as its
pointless to assign a value and then immediately reassign on
line 286
I don't quite follow? If I do that, 'manifests' won't get defined when
the exception is thrown. It's analogous to:
Note that I said to move it *inside* the except case, like this:
try:
manifests = ...
except ...:
manifests = []
...
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
