On 05/22/12 01:45, Edward Pilatowicz wrote:
hey all,
so i've finally got the parallel linked images code ready.
you can find the webrev here:
https://cr.opensolaris.org/action/browse/pkg/edp/pkg.pli.cr1/webrev/
[snip]
Apologies if the feedback comes in drips, but I'm just noting things as
I use this changeset as a basis for future work.
In pkgremote, having all the functions prefixed with "call_" seems
pointless. .setup, .start, .isdone, .rv etc... seem more appropriate to
me as an interface for other classes to use. I also find it strange that
call_rv returns quite a bit more than just the return value. I think
"result" might be a more intuitive name.
It might also be worth thinking about grouping the __rpc* state and the
__call* state into two small classes (or a dict, or a ...) instead of
having so many variables all with the same prefix. Alternatively, just
remove __call or __rpc, though I'm less excited about that.
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
