On Mon, Jun 11, 2012 at 01:57:50PM -0700, Brock Pytlik wrote: > On 06/10/12 22:59, Edward Pilatowicz wrote: > >[snip] > >>And finally, I propose that unless some extraordinarily compelling > >>reason exists, that no pylint disable commands be allowed into the > >>source. Since we control lint, we should either fix the exception, > >>turn off the exception, or fix the code. > >> > >i don't think that's realistic. there are multiple situations that i > >can think of (wildcard imports, relative imports, no exception specified > >when catching exceptions) that we generally want to avoid, but there > >will always be special case there will be exceptions. but having these > >errors enabled in pylint will force us to consider which case really > >should be special, and otherwise fix the issue. (banning the temporary > >disabling of pylint messages would be like saying you can't use LINT > >directives in C code. not very realistic.) > That's why I allowed the "extraordinarily compelling reason" out > clause. I just think we need the bar set really really high. >
agreed. ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
