On 06/21/12 04:38 PM, Danek Duvall wrote:
Erik Trauschke wrote:

On 06/21/12 04:26 PM, Danek Duvall wrote:
Erik Trauschke wrote:

https://cr.opensolaris.org/action/browse/pkg/erisch/7178587/webrev/

Looks fine to me, though it looks to me like we don't ever translate these
messages.  Perhaps we should be doing that, but it needn't be this
changeset.

Is there anything I need to change to get these into the list of messages
which are translated?

I think the thing to do is to wrap the strings themselves in N_(), and then
put _() around their use in the if clauses down below:

     server_err_msg = N_("""... blah blah blah ...""")

     if code == SERVER_ERROR:
         msg += _(server_err_msg)

If you do a full build, you should see the messages end up in po/pkg.pot.
That gets passed on to the L10N folks, and once we get translations back,
we should see the client spitting the translated messages out.

So should I file another bug to convert all the messages to this scheme? Not exactly sure how I would test this correctly.

Erik


Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to