On Fri, Jul 20, 2012 at 08:28:45PM -0600, Dave Vadovszki wrote: > On 07/20/12 18:53, Edward Pilatowicz wrote: > >On Fri, Jul 20, 2012 at 04:45:17PM -0600, Dave Vadovszki wrote: > >>Hi All, > >> > >>7185359 testsuite should produce xml coverage with -c > >>http://monaco.us.oracle.com/detail.jsf?cr=7185359 > >> > >>https://cr.opensolaris.org/action/browse/pkg/dvadovsz/7185359_v1/ > >> > >this changes look good to me, although i thought dan had asked to > >continue generating coverage reports for the test suite. perhaps we run > >coverage one more time to generate a report that focuses on just the > >test suite? > > > >ed > Well there's a couple ways to handle that. It's pretty easy to > generate two reports in tests/run.py. We would basically call > 'coverage xml --include "/*/proto/*"' (plus our standards omits like > we do today), and also call 'coverage xml --omit "/*/proto/*"' which > should give us the tests coverage. > > Worth noting, we don't actually have to do this from within > tests/run.py. It can also be run after the fact. > > # tests/run.py -j 8 -c > ... > # coverage html --omit "/*/proto/*" -d tests_html_cov > > The trickier part is representing this in hudson in a logic way. As > far as I can tell, a single job can not track two different sets of > coverage. We could create a couple sub jobs, dependent on pkg-build, > to parse and track the coverage reports separately. > > I feel like what is currently implemented keeps things simple, and > we still have a manual way to get at coverage within testing when we > need it. If it's important to track the test coverage over time, > it'll be a little trickier to configure in hudson, but should be > doable in a day or two. >
i think that if we suite generated the two reports (one for the shipping code and one for the test suite) that'd be ideal. anyone doing work could easily check if they've changed the coverage of the test suite substantially. as for hudson i think we'd just want to display code coverage for the shipping code since in the end that's the most important. ed _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
