hey dave,
i just pushed your changeset. please mark the bug "fix available" and
add the following keyword:
changeset=16919088d48f51d85fea2cfbb552403d2c0ae7b7
thanks,
ed
On Fri, Aug 24, 2012 at 03:14:51PM -0600, Dave Vadovszki wrote:
> On 08/17/2012 07:53 PM, Edward Pilatowicz wrote:
> >On Thu, Aug 16, 2012 at 04:09:26PM -0600, Dave Vadovszki wrote:
> >>On 07/23/2012 03:13 PM, Edward Pilatowicz wrote:
> >>>i think that if we suite generated the two reports (one for the shipping
> >>>code and one for the test suite) that'd be ideal. anyone doing work
> >>>could easily check if they've changed the coverage of the test suite
> >>>substantially. as for hudson i think we'd just want to display code
> >>>coverage for the shipping code since in the end that's the most
> >>>important.
> >>>
> >>>ed
> >>https://cr.opensolaris.org/action/browse/pkg/dvadovsz/7185359_v2/webrev/
> >>
> >>This outputs two separate reports for proto and tests coverage. I
> >>also added a parameter to -c to specify xml or html reporting for
> >>coverage.
> >>
> >>There's an interesting snag in displaying coverage for for tests/api
> >>where Hudosn instead shows you a page telling you how to use it's
> >>own Remote API. I'm still trying to figure out how to disable this
> >>"feature".
> >>
> >you have some commented out lines of code.
> >otherwise it looks good to me.
> >thanks for generating the two sets of reports.
> >
> >ed
>
> I haven't seen any other comments, so this is probably good to go. I
> removed the lines of commented debug code. Anyone care to do a push?
>
> Dave
>
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
