On 08/28/12 02:21 PM, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains changes for the following RFE:
>
> 7140597 facets are ORed even between different top-level facet
> categories
>
> https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-facet/webrev/
In your man page, the example manifest snippet uses foo.html, but the text
beneath describes "api.html"
Also I don't understand that example:
file path=usr/share/doc/html/foo/foo.html facet.doc=all facet.doc.html=all
In the above example, api.html will only be installed if both the 'doc'
and 'html' facets are \fBtrue\fR in the image. This allows administrators
to exclude only HTML-format documentation without excluding plain text
documentation.
Wouldn't the existing system handle that case by using simply:
file path=usr/share/doc/html/foo/foo.html facet.doc.html=true
and then setting facet.doc.html=false ? Or having only html docs
by setting facet.doc*=false facet.doc.html=true ? I don't see the benefit of
setting all for a subset facet here.
The examples in the bug report make more sense to me:
facet.doc vs facet.locale
facet.devel vs facet.locale
facet.doc vs facet.devel
Perhaps that's what the api.html reference was going for?
file path=usr/share/doc/html/foo/api.html facet.doc=all facet.devel=all
Also, pkg(1) always uses capitalized True & False for change-facet arguments,
not the lower-case versions that pkg(5) used - making the two consistent would
be nice.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
