Tim,

There's a webrev, and incremental at:

https://cr.opensolaris.org/action/browse/pkg/timf/periodic-recv-1

I've skimmed through this and from a cursory view, it looks sound.
I'll take a deeper look soon but I do have a couple of comments:

        1) The dataset creating service seems rather awkwardly named.
        I'd suggest dropping the "varshare" aspect of the name since it
        seems an implementation detail. Perhaps just
        svc:/application/pkg/repositories-setup?

        2) The "crontab_period" property is rather novel but supplying
        a crontab(4) fragment seems, again, awkward. I realize breaking
        this into five separate properties is probably overkill but
        still, I'm not crazy with the crontab fragment approach
        (although I'm not sure what sort of syntactic sugar might make
        sense especially when we're talking about smf(5) properties).
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to