On 02/28/13 05:02 PM, Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issue:

16389464 multiple whitespaces in action path can cause package
metadata errors

https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-16389464/webrev

src/modules/manifest.py
1151+
Is there a reason for inverting the if statement and not keep it the way it was? I understand you might be opposed to begin an "if-else" statement with an "if not" but it seems you just increase indentation unnecessarily in this case.

src/tests/api/t_manifest.py
would it make sense to have dirs with some other funky characters? I never looked into this but it seems like even tabs and newlines are allowed in path names. Do we actually have tests which make sure we don't have invalid characters in path/file names (probably in a different section of the code, though)?

Otherwise, lgtm.

Erik



-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to