On 03/05/13 14:09, Erik Trauschke wrote:
On 02/28/13 05:02 PM, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issue:
16389464 multiple whitespaces in action path can cause package
metadata errors
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-16389464/webrev
src/modules/manifest.py
1151+
Is there a reason for inverting the if statement and not keep it the way
it was? I understand you might be opposed to begin an "if-else"
statement with an "if not" but it seems you just increase indentation
unnecessarily in this case.
I didn't invert this for style reasons. It was changed so that it now
falls through to loading the full manifest if the cache file didn't
exist and if the file did exist, but was invalid.
src/tests/api/t_manifest.py
would it make sense to have dirs with some other funky characters? I
never looked into this but it seems like even tabs and newlines are
allowed in path names.
We don't support newlines in action attributes in general; tabs are
already covered in my tests.
Do we actually have tests which make sure we don't have invalid
characters in path/file names (probably in a different section of the
code, though)?
I don't know; I'd expect them to be part of api.t_action.
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
