On 02/27/2018 03:32 AM, Michael Stapelberg wrote: > > There's a `docs/.gitignore`, it's in a subdirectory. Files-Excluded > will remove it from the orig tarball, right ? Is it really suitable here ? > > Correct, and up to you (see the caveat which tincho expressed). Bug > #812721 discusses a gbp import-ref command which would honor > Files-Excluded, but we’re not quite there yet. So, if you want to > stick to orig tarballs for the time being, Files-Excluded will work.
In the end I solved it a better way, simply by being more selective in debian/docs. > > > > For the moment the only package in which I exclude a file from > installation is done this way: > > override_dh_auto_install: > dh_auto_install > find $(CURDIR)/debian -name '.tool' -type d -prune -exec rm -r > '{}' + > > > nit: use find’s -delete action? Nope :) `-delete` only works for files, not directories. My concern here is not so much about the find command, but it's more the location where I look for files. Here I use $(CURDIR)/debian, and it works, but I'm surprised that there is not a "BUILDDIR" variable defined, or something similar. I'm not sure if using $(CURDIR)/debian works for every package in every situation, I don't know enough about the internals. > > Ah, I see what’s wrong here: you are supposed to run lintian on a > .changes file, so that it can inspect both the binary packages (*.deb) > and the source package (*.dsc). Indeed, when building gogoprotobuf and > running “lintian golang-gogoprotobuf_0.5-1_amd64.changes”, I don’t get > any warnings about statically linked binaries. Ahhhh indeed, thanks for pointing that. > > >> >> >> >> In the `-dev` packages, is `${shlibs:Depends}` needed ? >> During the builds >> I see `unknown substitution variable ${shlibs:Depends}` >> passing by. >> >> >> The messages implies it’s not required. I’m not entirely sure, >> but would suggest removing it for now. > > Ok. I think it should be also changed in dh-make-golang, should I > look there and issue a PR, or do you prefer not to touch it for now ? > > > Please feel free to send a PR! :) Done ! Thanks again for all the explanations, that helps a lot. Arnaud
_______________________________________________ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers