Dear Sebastiaan, thank you for the review. All issues should be fixed now.
regards antonio Il 17/11/18 19:31, Sebastiaan Couwenberg ha scritto: > On 11/17/18 6:48 PM, Antonio Valentino wrote: >>>> The package is ready for review. >>> >>> I'll review the package when it's available in the new repository/ >> >> just pushed to salsa > > Comments follow. > > * debian/changelog > > Use urgency=medium instead of low. That's been the new default in dch > for a while. Saves you 5 days waiting for testing migration (assuming > autopkgtest doesn't fail). > > * debian/compat > > Since the package is unlikely to get backported 11 is fine (and > matches pycoast), but 9 is recommended as mentioned in the team > policy: > > " > We currently recommend to use the level 9 which is available in > current stable (stretch) and backported to oldoldstable (wheezy). It > is also the version supported in Ubuntu trusty and Ubuntu xenial. If > support for these is not required version 10 or 11 can be used." > " > > * debian/control > > Restructure the control file with cme like the other packages, with > every dependency on a separate line among others. > > There is no package for pillow in the Build-Depends which according to > setup.py is required for tests. > > README.rst mentions running selftest.py, but that file is not included > in the upstream source from PyPI, it's in the git repo though. > > * debian/copyright > > The license is not Expat, its terms are close to the NTP license, but > are not an exact match. > > I would use the aggdraw short name for it. > > Consider using Files-Excluded for the .egg-info directory which is > autogenerated by the buildsystem. And use repacksuffix+ds in the watch > file. No need for debian/source/options in that case. > > * debian/watch > > Why use pypi.d.n instead of GitHub releases like pycoast? > > No need to repack the egg-info in that case either. > > Kind Regards, > > Bas > -- Antonio Valentino
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pkg-grass-devel mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-grass-devel
