On 2019-07-16 13:17, Christoph Berg wrote:
We have decent test coverage now, can we drop this bit in postgis?
We might be able to drop the PIE handling on Ubuntu, but we're not
testing on those Ubuntu environment AFAIK.
# Disable PIE on Ubuntu where it's still problematic
VENDOR_DERIVES_FROM_UBUNTU ?= $(shell dpkg-vendor --derives-from
Ubuntu && echo yes)
DISTRIBUTION_RELEASE := $(shell lsb_release -cs)
ifeq ($(VENDOR_DERIVES_FROM_UBUNTU),yes)
ifneq (,$(filter $(DISTRIBUTION_RELEASE),trusty xenial bionic))
export DEB_BUILD_MAINT_OPTIONS=hardening=+all,-pie
endif
endif
trusty can be removed, it's EOL.
The build on xenial probably still fails with PIE, bionic may have the
required fixes too.
We use the distribution to disable pie because it was not clear which
gcc version included the fix, that would have been a better test.
Leaving this code in place until bionic is EOL is fine with me, it
doesn't bother me. And it prevents issues for OSGeoLive and UbuntuGIS
where they do build the package on those environments.
If you can confirm that pie now works on xenial & bionic we can drop
this code (and the lsb_release B-D).
Kind Regards,
Bas
_______________________________________________
Pkg-grass-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-grass-devel
