On 8/26/20 5:39 PM, Felix Delattre wrote: > Felix Delattre pushed to branch master at Debian GIS Project / > libapache2-mod-tile > Commits: > 24720515 by Felix Delattre at 2020-08-25T20:24:18+00:00 > added systemd.service > > - - - - - > 2757a3eb by Felix Delattre at 2020-08-26T15:18:33+00:00 > moved helper scripts to a suitable location > > - - - - - > 77d80483 by Felix Delattre at 2020-08-26T15:27:34+00:00 > prepared libapache2-mod-tile to work equally with renderd and tirex > > - - - - -
Commit messages are sentences, they start with a capital and end with a period. > ===================================== > debian/control > ===================================== > @@ -1,7 +1,7 @@ > Source: libapache2-mod-tile > Maintainer: Debian GIS Project <[email protected]> > Uploaders: Felix Delattre <[email protected]> > -Section: science > +Section: web Don't change the section of the source package. > Priority: optional > Build-Depends: debhelper (>= 10~), > dh-apache2, > @@ -18,11 +18,12 @@ Homepage: https://wiki.openstreetmap.org/wiki/Mod_tile > > Package: libapache2-mod-tile > Architecture: any > -Section: httpd > -Depends: libjs-openlayers, > - renderd | tirex-master, > - ${shlibs:Depends}, > +Section: web > +Depends: ${shlibs:Depends}, Especially when you duplicate that same section for a binary package. > ===================================== > debian/copyright > ===================================== > @@ -31,7 +31,9 @@ Copyright: 1990, 1993, The Regents of the University of > California > License: BSD-3-clause > > Files: debian/* > -Copyright: 2016, Bas Couwenberg <[email protected]> > +Copyright: > + 2020, Felix Delattre <[email protected]> > + 2016-2020, Bas Couwenberg <[email protected]> > 2011-2014, Kai Krueger <[email protected]> > 2009, Frederik Ramm <[email protected]> > License: GPL-2+ Align the copyright holders. See other packages for examples. Hint: Copyright: <year>, <holder> <year>-<year>, <holder> > ===================================== > debian/libapache2-mod-tile.apache2 > ===================================== > @@ -1,3 +1,2 @@ > mod src/.libs/mod_tile.so > mod debian/tile.load > -conf debian/libapache2-mod-tile.conf Why do you remove the config? > ===================================== > debian/libapache2-mod-tile.dirs deleted > ===================================== > @@ -1,2 +0,0 @@ > -usr/share/libapache2-mod-tile > -var/lib/mod_tile Why is this removed? > ===================================== > debian/libapache2-mod-tile.install > ===================================== > @@ -1,5 +1,3 @@ > debian/tile.load etc/apache2/mods-available > slippymap.html usr/share/libapache2-mod-tile > munin/mod_tile* usr/share/munin/plugins > -openstreetmap-tiles-update-expire usr/bin > -osmosis-db_replag usr/bin Why aren't these binaries installed? > ===================================== > debian/libapache2-mod-tile.links deleted > ===================================== > @@ -1 +0,0 @@ > -usr/share/javascript/openlayers usr/share/libapache2-mod-tile/openlayers Why is this removed? > ===================================== > debian/libapache2-mod-tile.postinst > ===================================== > @@ -3,9 +3,6 @@ > set -e > > if [ "$1" = configure ] ; then > - if [ -e /var/lib/mod_tile ]; then > - chown www-data:www-data /var/lib/mod_tile > - fi Why is this removed? > # only enable on new installs, not on upgrades > if [ -z "$2" ] ; then > > > ===================================== > debian/libapache2-mod-tile.conf → debian/libapache2-renderd.conf > ===================================== > @@ -1,6 +1,6 @@ > -Alias /mod_tile /usr/share/libapache2-mod-tile > +Alias /mod_tile /var/lib/mod_tile > > -<Directory /usr/share/libapache2-mod-tile> > +<Directory /var/lib/mod_tile> > Options Indexes FollowSymLinks MultiViews > AllowOverride None Why this change? /usr/share/<package> is the appropriate place for webapps. https://wiki.debian.org/Apache/PackagingFor24 Please motivate your changes better. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 _______________________________________________ Pkg-grass-devel mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-grass-devel
