Hi Pino! On Sat, Apr 28, 2018 at 12:26:12PM +0200, Pino Toscano wrote: > Hi, > > at qt/qtdatavis3d.git I pushed the packaging I did for the qtdatavis3d > module of Qt; rusty as I am wrt Qt stuff, I looked at the other Qt > modules for naming/build/testing stuff, and I think it should be OK. > A review from anyone working more often on Qt stuff would be nice, to > be sure I did not miss anything important. (I can handle the upload > myself, of course.)
debian/copyright:
- I think GPL-3-Qt-v2 can be just GPL-3. The commercial part does not
apply to Debian, and the remaining part is just GPL v3. Also I think
this variant is older than one without -v2 prefix.
- LGPL-3+ description is too short. Also we usually use te same license
as upstream for packaging, but this is of course your choice.
debian/rules:
- The {C,CXX,LD}FLAGS exports are not needed with the current debhelper.
- QT_LOGGING_RULES="default.debug=true" is also not needed with qtbase
≥ 5.9.2+dfsg-7.
- “Fix wrong path in pkgconfig file” should be also not needed.
(I understand you copied this from somewhere else, where we forgot to
remove such lines.)
debian/changelog, debian/control:
- I think we started using upstream names for new packages (with
-everywhere- instead of -opensource-, see e.g. qtgamepad).
Otherwise looks fine, thanks for taking care of it.
--
Dmitry Shachnev
signature.asc
Description: PGP signature
-- https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-kde-talk
