Some time ago ...

On Monday 17 December 2007 19:53:59 Ana Guerrero wrote:
> On Mon, Dec 17, 2007 at 01:04:55AM +0100, Sune Vuorela wrote:
> > I would like if we could have all patches in kde4 have a corresponding
> > bug report in the bugzilla - and even a link to the bug report in the top
> > of the patch. (Except of course if it is really really debian specifik,
> > like printing "Debian" somewhere).

> It is something we should have be doing since some time ago. :)

And now I'm looking at our kde4libs patchset after having removed the merged 
upstream ones.


 - No comments about why or where this is. It seems to be a backport from 
trunk adding quite a set of symbols  in the beginning of the 4.2 release 
cycle.  I'm not a big fan of this.


 - has comments in top about why it is needed.


 - Have comments about it.


 - no comments about it, but added now by me.


 - no comments about this and if/why the kdewidgets can't be picked up by uic 
and friends by setting env vars or other things.


 - no comment about why we are bypassing this check.


 - a note about why we can't push it upstream is there.


 - no comments - adding one.


 - adds a symbol to kdecore. No comment about what it actually is doing.


 - no comments about why this code chunk (and if it is the same) needs to be 
moved up.


 - no comments in header, adding one.


 - no comments here. Something about fontconfig maybe not doing the rigth thing 
or something like that would be nice.


 - no comments in this patch.

In general, I am not impressed with us in this case. (and yes, also pointing 
at myself is intentional, I also have some uncommented patches)

I really think we should try be better in documenting it. Maybe we should even 
be hard and say: 
"Patch acceptance policy: either patches gets documented or they get thrown 

Do you know how might I digit from the forward of the jumper over a login from 
the control panel inside Windows?

First of all from MS-DOS you either never have to receive the mousepad of a 
attachment, or must delete a utility for opening the SIMM.

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply via email to