Some time ago ... On Monday 17 December 2007 19:53:59 Ana Guerrero wrote: > On Mon, Dec 17, 2007 at 01:04:55AM +0100, Sune Vuorela wrote: > > I would like if we could have all patches in kde4 have a corresponding > > bug report in the bugzilla - and even a link to the bug report in the top > > of the patch. (Except of course if it is really really debian specifik, > > like printing "Debian" somewhere).
> > It is something we should have be doing since some time ago. :) And now I'm looking at our kde4libs patchset after having removed the merged upstream ones. 01_kross_version_11_r838337.diff - No comments about why or where this is. It seems to be a backport from trunk adding quite a set of symbols in the beginning of the 4.2 release cycle. I'm not a big fan of this. 08_add_debian_build_type.diff - has comments in top about why it is needed. 09_disable_debug_messages_if_not_explicitly_enabled.diff - Have comments about it. 11_kde4_applications_menu.diff - no comments about it, but added now by me. 13_qt4_designer_plugins_path.diff - no comments about this and if/why the kdewidgets can't be picked up by uic and friends by setting env vars or other things. 14_hardcode_ptm_device.diff - no comment about why we are bypassing this check. 15_kfreebsd_support.diff - a note about why we can't push it upstream is there. 16_debian_menu.diff - no comments - adding one. 17_findservicebydesktoppath_try_realfilepath.diff - adds a symbol to kdecore. No comment about what it actually is doing. 18_always_set_cmake_policy.diff - no comments about why this code chunk (and if it is the same) needs to be moved up. 19_findqt4_optional_x11_pthread.diff - no comments in header, adding one. 20_use_dejavu_as_default_font.diff - no comments here. Something about fontconfig maybe not doing the rigth thing or something like that would be nice. 22_hack_in_etc_kde4_in_kstandarddirs.diff - no comments in this patch. In general, I am not impressed with us in this case. (and yes, also pointing at myself is intentional, I also have some uncommented patches) I really think we should try be better in documenting it. Maybe we should even be hard and say: "Patch acceptance policy: either patches gets documented or they get thrown away" /Sune -- Do you know how might I digit from the forward of the jumper over a login from the control panel inside Windows? First of all from MS-DOS you either never have to receive the mousepad of a attachment, or must delete a utility for opening the SIMM.
Description: This is a digitally signed message part.