On Tue, Jun 08, 2010 at 01:37:24PM +0200, Reinhard Tartler wrote:
On Tue, Jun 08, 2010 at 11:36:44 (CEST), Jonas Smedegaard wrote:

On Mon, Jun 07, 2010 at 08:28:05PM +0000, fabian-gu...@users.alioth.debian.org 
wrote:
The following commit has been merged in the master branch:
commit 552a01450aa8c3492e3264eb8509254488b99d21
Author: Fabian Greffrath <fab...@debian-unofficial.org>
Date:   Mon Jun 7 21:56:08 2010 +0200

   Add debian/gbp.conf.

diff --git a/debian/gbp.conf b/debian/gbp.conf
new file mode 100644
index 0000000..1615f89
--- /dev/null
+++ b/debian/gbp.conf
@@ -0,0 +1,6 @@
+[DEFAULT]
+upstream-branch = upstream
+debian-branch = master
+upstream-tag = upstream/%(version)s
+debian-tag = debian/%(version)s
+pristine-tar = True


I noticed above several times, and have a general comment:

I suggest to only state unusual things, not defaults.

Concretely I suggest to only state the following:

[DEFAULT]
pristine-tar = True

What problem does this solve?

Removing the lines forces maintainers to stick with the defaults of the removed fields. Not that I would do that, and TBH, I don't have a particularly strong opinion on this, I'm just wondering. But it seems that you have an opinion on this because you mentioned it here. I'm trying to understand it.

It solves no "problem", but improves readability to not list unnecessary information.

It seems from above that you consider the information necessary. Could you elaborate on that, as I fail to understand how that is.


Kind regards,

 - Jonas

--
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to