On Sun, 2010-09-12 at 18:28 +0200, Alessio Treglia wrote:
> On Sun, Sep 12, 2010 at 5:25 PM, Hans-Christoph Steiner <h...@at.or.at> wrote:
> >  *README.txt and LICENSE.txt are part of the upstream Pd library format, so
> > they need to be included in the library folder (i.e.
> > /usr/lib/pd/extra/pd-arraysize).  Jonas said the text file should be in the
> > lib, and a symlink in /usr/share/doc since /usr/lib is required and
> > /usr/share is optional.
> 
> Well, I'll revert my changes.

I noticed that you left debian/docs. Do you think that might conflict
with the README.txt in debian/links?

> >  *does debhelper set $(STRIP) in the Makefile? if so, the override_dh_strip
> > stuff is not necessary since, as you said in your commit comments, there is
> > a $(STRIP) line in the upstream install target.
> 
> Please have a look at this [1]:
> 
> install -p -m 644 arraysize-meta.pd \
>               
> /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize
> test -z "arraysize.c" || (\
>               install -p -m 644 arraysize.pd_linux
> /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize
> && \
>               strip --strip-unneeded -R .note -R .comment
> /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize/arraysize.pd_linux)
> test -z "" || \
>               install -p -m 644  \
>                       
> /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize
> 
> 
> So there is no need to re-strip the binaries in debian/rules.
> 
> [1] 
> http://debomatic64.debian.net/unstable/pool/pd-arraysize_0.1-1/pd-arraysize_0.1-1.buildlog

Excellent!  I'll remove the override_dh_strip targets.  Is this a
product of using dh_auto_install instead of make?

.hc




_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to