On Sun, Jan 16, 2011 at 09:41:54PM +0100, IOhannes m zmölnig wrote:
On 01/15/2011 11:28 AM, Jonas Smedegaard wrote:
On Fri, Jan 14, 2011 at 07:11:45PM +0000,
zmoelnig-gu...@users.alioth.debian.org wrote:
   clean up on 'clean'

   the "clean" target fails to remove some files, because of the
dfsg-stripping of
   the sources, which removed some directories, making "make
distclean" fail in the
   lib/ directory and not finishing its job

Seems better to me then to patch autotools than partly reinvent upstream clean target.

i'm not sure whether i really understand.

the problem is:
- - we strip some directories to get dfsg-clean code
- - we patch autotools to reflect these changes
- - when doing "clean", the quilt-patches are not applied, thus autotools
do not know about the missing directories, thus "make distclean" fails

I believe you are wrong about the last part.

I believe unpatching is done _after_ cleaning.

If interrupted during build (which often happens when tuning the build routines) then all sorts of odd things can occur, but with dpkg-source format "3.0 (quit)" patches are applied _before_ invoking any rules, and thus should re unapplied _after_ cleanup.

PS: please send replies to [SCM] to -maintainers, as i thinkthat this is
the appropriate list for discussion.

You are absolutely right. My fingers are just programmed to hit "L" in Mutt when targeting a list - not "G" which somewhat counterintuitively is the appropriate action when commenting on commit messages.

 - Jonas

 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

pkg-multimedia-maintainers mailing list

Reply via email to