Review for Package: libswitch-perl [Summary] MIR team NACK
There seem to be better, more modern ways to do this without adding a very old dependency to main. This would need a very good explanation why it would be impossible to use perl builtins of the this decade to solve the same. [Duplication] This looks wrong to be added to main in 2023. I mean this package clearly states "This is an obsolete module provided for compatibility since it is being removed from the core. For perl 5.10 and above the "given/when" builtins are much preferred." Perl 5.10 was in Ubuntu since intrepid, that is 13 years ago. New code should just use [1] So if this is only for compat with very very old code, why is it suddenly needed in devscripts? I have found [2] to be the reason which on a glance does look wrong to force the use of this perl module. First I thought it might be due to the use of regex, but even that seems to be known strange bugs in switch and workign fine with given/when [3]. Looking forward to 24.04 as the next LTS it feels wrong to add this for another decade. Did I mention there was no update since 2014? Instead please consider to recode this new code, propose it to Debian and get rid of the dependency. [1]: https://www.geeksforgeeks.org/perl-given-when-statement/ [2]: https://salsa.debian.org/debian/devscripts/-/commit/3ebcb3f5748aa758cdf701d413a99b21ef10aab2 [3]: https://stackoverflow.com/questions/1181685/why-doesnt-my-regular-expression-work-with-perls-switch-module ** Changed in: libswitch-perl (Ubuntu) Status: New => Incomplete ** Changed in: libswitch-perl (Ubuntu) Assignee: Christian Ehrhardt (paelzer) => (unassigned) -- You received this bug notification because you are a member of Debian Perl Group, which is subscribed to libdigest-md5-file-perl in Ubuntu. https://bugs.launchpad.net/bugs/2007279 Title: [MIR] libdigest-md5-file-perl & libswitch-perl (dependency of devscripts) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/devscripts/+bug/2007279/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~pkg-perl-maintainers Post to : [email protected] Unsubscribe : https://launchpad.net/~pkg-perl-maintainers More help : https://help.launchpad.net/ListHelp
