Review for Package: libdigest-md5-file-perl Hmm, another package not touched in ages, so one can think it is stable or neglected? In any case this isn't much code, but just being 400 lines it has plenty of code duplication (all _, _hex, _base64 could be unified) and plenty of whitespace damage which does not increase confidence.
This is again used for a rater small change which might be resolved with less dependencies [1]. [1]: https://salsa.debian.org/debian/devscripts/-/commit/f50644205a5fdd1d9ca91bdf01c98ba364a80d15 MIR team NACK Please have a look at implementing this without perl-dependency-proliferation and propose it to devscripts on Salsa. [Duplication] What does it provide?: 1. md5 of files, but Digest::file can deal with that just fine https://perldoc.perl.org/Digest::file This can be just one line without this module https://stackoverflow.com/a/53016159/6361589 This is part of base perl and thereby preferred 2. md5 for url, doing that directly would be just one line more https://stackoverflow.com/questions/13679914/perl-get-md5-hash-of-a-fetched-file libwww-perl already is in the dependencies of devscripts and in main. Using that is only a minor change but saves many people one more perl module on disk used for something that would easily work without. ... stopping evaluation here. I might be convinced to re-consider it if there is a strong argument for it that I have missed, but without that it really looks like a minor change in src:devscripts that will help to: a) keep developer system free of more perl lib sprawl on disk b) keep the more actively supported set of libs in main under control ** Changed in: libdigest-md5-file-perl (Ubuntu) Assignee: Christian Ehrhardt (paelzer) => (unassigned) ** Changed in: libdigest-md5-file-perl (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Debian Perl Group, which is subscribed to libdigest-md5-file-perl in Ubuntu. https://bugs.launchpad.net/bugs/2007279 Title: [MIR] libdigest-md5-file-perl & libswitch-perl (dependency of devscripts) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/devscripts/+bug/2007279/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~pkg-perl-maintainers Post to : [email protected] Unsubscribe : https://launchpad.net/~pkg-perl-maintainers More help : https://help.launchpad.net/ListHelp
