On Mon, Apr 14, 2014 at 2:53 AM, Riku Voipio <[email protected]> wrote: > Hi, > > On Fri, Apr 11, 2014 at 09:55:39AM -0300, Felipe Sateler wrote: >> I'm not sure I follow. If I understand correctly, the workaround is >> needed because Debian armel targets arm < v6, but that file has >> runtime detection to use armv6 code should be compiled anyway. The >> problem seems to be a wrong file name (fixed in git already). Could >> you please expand on why you think it is no longer needed? > > Thanks for looking into this promptly. I see you already uploaded > a fixed version to unstable. Some food for thought below. > > Well I simply compiled pulseaudio without the debian/rules setting and > built. Previously pulseaudio would FTBFS without the line. Looking > closer, the pa now has a configure check: > > checking support for required armv6 instructions... no > > so HAVE_ARMV6 is not set, and I think the file will end up empty > even if compiled with workaround. from my POV, armv6 hardware > is rare enough (except for rasberry py, where you should use raspbian), > so keeping the workaround is not strictly neccesary. > > The alternative would be to fix it properly in the configure.ac, by adding > ARMV6_CFLAGS="-marmv6" in case the the configure check for armv6 > instructions fails to compile without it.
OK, so currently the workaround is a noop. Moreover, inspecting the code I see that the function does not have runtime protection, so it might cause pulseaudio to crash if invoked when not available. I'm dropping the workaround. Thanks -- Saludos, Felipe Sateler _______________________________________________ pkg-pulseaudio-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-pulseaudio-devel
