On Wed, Jun 27, 2012 at 05:03:54PM -0500, Serge Hallyn wrote: > Quoting Roger Leigh ([email protected]): > > On Wed, May 30, 2012 at 01:11:55PM -0500, Serge Hallyn wrote: > > > Here is a debdiff showing the change I was suggesting. It works under > > > debootstrap. The !ischroot case is unchanged, as is the case under > > > chroot where /dev is a mounpoint. > > > > I can't see anything wrong with this after considering all the > > different conditions it could run in, so it's applied in git > > (minor whitespace changes only), and will be in the next upload. > > Thanks - however to the bottom of the ubuntu bug (in particular > https://bugs.launchpad.net/launchpad/+bug/974584/comments/20 > and > https://bugs.launchpad.net/launchpad/+bug/974584/comments/21 > ) vorlon has proposed an improved variation. Thanks and sorry > for the inconvenience.
You just missed the cutoff, since I just spent the evening testing for upload. I didn't want to retest everything again, so vorlon's improvement will have to go into the next upload. His outline of the various different end states is good, and highlights just how annoying it is having to handle upgrades in chroots. Better covering them is very desirable where possible, though as he points out, there are certain cases where it's simply not possible to safely proceed. I'll review and test this for the next upload. BTW, vorlon's code uses "mountpoint -q /dev/". Is the trailing / in /dev/ significant, e.g. to cope with /dev being a symlink? Many thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linux http://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 _______________________________________________ Pkg-sysvinit-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-sysvinit-devel
