Verbally discussed issue with cfu, was given cond ack upon fixing the issue:
Issue has been fixed, checked into master. commit cdb8d2f7a3655b4ba97b70a9460721e0d2d8afe7 Author: Jack Magne <[email protected]> Date: Tue Nov 15 17:37:07 2016 -0800 Change lifecycle at end of enrollment if it is not already set. TPS throws "err=6" when attempting to format and enroll G&D Cards. https://bugzilla.redhat.com/show_bug.cgi?id=1320283 This fix addresses this bug , but also: Fixes this issue: Applet upgrade during rekey operation results in formatted token. Also, it takes care of a related issue where the new apdu needed for the lifecycle state causes the testing tool "tpslcient" to seg fault. The fix here is a minimal fix to have tpsclient return an error when it gets this apdu it can't handle, instead of crashing. Closed ticket # 2544 ----- Original Message ----- > From: "Christina Fu" <[email protected]> > To: [email protected] > Sent: Wednesday, November 16, 2016 6:25:49 PM > Subject: Re: [Pki-devel] [pki-devel][PATCH] > > > > I compared this patch with the original C patch. There was a check in C that > does not exist in your Java patch: > 1019 > if(data.size() != 3){ > > 1020 > lifecycle = 0xf0; > > 1021 > RA::Error(LL_PER_PDU, "RA_Processor::GetLifecycle", "apdu response is the > wrong size, the size is: %x", data.size()); > > 1022 > goto loser; > > 1023 > } > > Why does it not apply in Java? > > Thanks, > Christina > > On 11/15/2016 06:20 PM, John Magne wrote: > > > > Ticket: TPS throws "err=6" when attempting to format and e : > https://fedorahosted.org/pki/ticket/2544 Fix tested on standard card, it > does what it is supposed to do. It checks first to make sure the lifecycle > state needs to be changed before attempting to do so. This will prevent any > cards that return an error when > one tries to over write the value with the same value it had before. > > > _______________________________________________ > Pki-devel mailing list [email protected] > https://www.redhat.com/mailman/listinfo/pki-devel > > > _______________________________________________ > Pki-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/pki-devel _______________________________________________ Pki-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/pki-devel
