On Tuesday 26 May 2009, Aaron J. Seigo wrote: > On Tuesday 26 May 2009, Marco Martin wrote: > > Hi all, > > was talking with richmoore about the api of libknotificationitem, wat did > > emerged is a thing i wasn't happy about but couldn't quite quantify > > before: > > > > 1) we have two way to set icons: by name and by pixmap, right now by name > > is setIcon() > > by pixmap is setImage() > > (that should reflect in dbus too) > > that looks a bit weird, would be better maybe setIconName() and > > setIcon()? > > setIcon in the rest of our API tends to take a QIcon ... but that's not > doable here... setIconName is ok though not much more satisfying than > setIcon tbh. it is at least more descriptive as to what it's doing and > doesn't interfere with the setIcon(QIcon) pattern in the rest of Qt/KDE API > > i don't like the idea of setIcon(QPixmap) though, as it's not an icon that > is being set, but rather an image.
it's a QIcon ( all the sizes in the icon are transmitted over dbus in an ImageVector) > > 2) void showMessage(const QString &title, const QString &message, const > > QString &icon, int timeout = 10000); > > > > should become > > > > void showMessage(const QString &message, const QString &title = > > QString(), const QString &icon = QString(), int timeout = 10000); > > looks fine though we'll have to hunt through all uses as the compiler won't > help us here i don't think. it was to permit to just do a showMessage(message) and yeah unfortunately would still compile :/ as far i know nobody uses it but we'll do a quick grep.. > > aaand, can quite big changes like the icon methods still be done? > > and when? now? after 4.3? > > before preferably. _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel