On Tuesday 26 May 2009, Marco Martin wrote: > Hi all, > was talking with richmoore about the api of libknotificationitem, wat did > emerged is a thing i wasn't happy about but couldn't quite quantify before: > > 1) we have two way to set icons: by name and by pixmap, right now by name > is setIcon() > by pixmap is setImage() > (that should reflect in dbus too) > that looks a bit weird, would be better maybe setIconName() and setIcon()?
another proposal: setIconByName setIconByPixmap that way we don't end up with a setIcon(QIcon) that the compiler would use silently when someone ports from KSystemTray to KNotificationItem (we really want to discourage use of the setIcon(QIcon) method) and it says exactly what it's doing. thoughts? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel