caspermeijn created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. caspermeijn requested review of this revision.
REVISION SUMMARY With this it is not nessecary to KAboutData::setProgramLogo. If the QApplication::setWindowIcon is set, then the AboutPage will automatically use that icon. TEST PLAN Tested with Discover, with only setWindowIcon, only setProgramLogo and both setWindowIcon and setProgramLogo REPOSITORY R169 Kirigami BRANCH about_icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23241 AFFECTED FILES src/controls/AboutPage.qml src/settings.cpp src/settings.h To: caspermeijn Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
