apol added a comment.
+1 LGTM, please address the @since bit INLINE COMMENTS > settings.h:81 > + */ > + Q_PROPERTY(QVariant applicationWindowIcon READ applicationWindowIcon > CONSTANT) > It could make sense to include the REVISION part: https://doc.qt.io/qt-5/properties.html REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23241 To: caspermeijn, mart, apol, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
