ngraham added a comment.

  This works great!
  
  In terms of the UI, it feels like we need a bit more logical separation 
between the groups now. I would adjust things (in this same patch) to be like 
this:
  
     Play audio feedback for changes to: [x] Audio volume
    
    Show visual feedback for changes to: [x] Audio volume
                                         [x] Microphone sensitivity
                                         [x] Mute state
                                         [x] default output
  
  You can add the spacing between groups with an item like this:
  
    Item {
        Kirigami.FormData.isSection: true
    }

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D28281

To: sgoth, #vdg, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to