----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review57887 -----------------------------------------------------------
looks good. I'll give it a run tomorrow in a real setup. src/declarativeimports/core/fadingnode.cpp <https://git.reviewboard.kde.org/r/116024/#comment40286> double ;; - Martin Gräßlin On May 13, 2014, 5:25 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116024/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 5:25 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Port IconItem to native QSGTexture including the animation. > This will save constantly uploading a new texture to OpenGL throughout the > animation. > > > Diffs > ----- > > .reviewboardrc 804529c > src/declarativeimports/core/CMakeLists.txt 9b3313d > src/declarativeimports/core/fadingnode.cpp PRE-CREATION > src/declarativeimports/core/fadingnode_p.h PRE-CREATION > src/declarativeimports/core/iconitem.h 92a5233 > src/declarativeimports/core/iconitem.cpp 9cb487c > > Diff: https://git.reviewboard.kde.org/r/116024/diff/ > > > Testing > ------- > > Test app: http://paste.kde.org/pl5pwdnel > > Test app shows for lots of icons a decrease from 40 -> 27Mb > apitrace has a lot fewer calls to glTexImage2D > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
