----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review64575 -----------------------------------------------------------
We probably don't want to show this if there is only one layout. Maybe check available list > 1 before setting valid to true. ksmserver/screenlocker/greeter/keyboardlayout.h <https://git.reviewboard.kde.org/r/119794/#comment45127> why is this mutable? ksmserver/screenlocker/greeter/keyboardlayout.cpp <https://git.reviewboard.kde.org/r/119794/#comment45121> this is blocking :( ksmserver/screenlocker/greeter/keyboardlayout.cpp <https://git.reviewboard.kde.org/r/119794/#comment45124> Needs a category so we know what has no such layout ksmserver/screenlocker/greeter/keyboardlayout.cpp <https://git.reviewboard.kde.org/r/119794/#comment45125> I'd do this only when get the signal that the layout has actually changed. (i.e don't re-use one function for setting from QML and when it's been set externally) ksmserver/screenlocker/greeter/keyboardlayout.cpp <https://git.reviewboard.kde.org/r/119794/#comment45123> blocking. ksmserver/screenlocker/greeter/keyboardlayout.cpp <https://git.reviewboard.kde.org/r/119794/#comment45122> This is blocking lookandfeel/contents/lockscreen/LockScreen.qml <https://git.reviewboard.kde.org/r/119794/#comment45126> anchors inside a RowLayout isn't needed. - David Edmundson On Aug. 14, 2014, 8:50 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119794/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 8:50 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This adds a button that allows toggling keyboard layout from the lockscreen. > It talks and listens directly to the KDED's keyboard module. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 > ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef > ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION > ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION > lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION > lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 > > Diff: https://git.reviewboard.kde.org/r/119794/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
