----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119794/#review64579 -----------------------------------------------------------
ksmserver/screenlocker/greeter/keyboardlayout.h <https://git.reviewboard.kde.org/r/119794/#comment45129> Not really a review comment for Dan, but for Marco et al. I'd like to take this and put it into a new QML plugin that I can use from a KeyboardLayout applet. Not sure where I'd put it, the natural place is with the keyboards kded module, but that's in plasma-desktop, and workspace can't depend on desktop...not unsolvable, we'd have to put ToolButton in a loader so it doesn't explode if it can't find the import. - David Edmundson On Aug. 14, 2014, 9:40 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119794/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 9:40 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This adds a button that allows toggling keyboard layout from the lockscreen. > It talks and listens directly to the KDED's keyboard module. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/CMakeLists.txt 7ac1846 > ksmserver/screenlocker/greeter/greeterapp.cpp 3af10ef > ksmserver/screenlocker/greeter/keyboardlayout.h PRE-CREATION > ksmserver/screenlocker/greeter/keyboardlayout.cpp PRE-CREATION > lookandfeel/contents/components/KeyboardLayout.qml PRE-CREATION > lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 > > Diff: https://git.reviewboard.kde.org/r/119794/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
