----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/#review65648 -----------------------------------------------------------
I need some the concept explaining, why would a developer set a fallbackpackage? Is it not always org.kde.breeze.desktop? autotests/data/testfallbackpackage/metadata.desktop <https://git.reviewboard.kde.org/r/120029/#comment45874> should testpackage get a metadata.desktop file too? autotests/fallbackpackagetest.cpp <https://git.reviewboard.kde.org/r/120029/#comment45875> This seems the variable names are backwards: the m_fallbackpackage is given a fallbackpackage of m_package autotests/fallbackpackagetest.cpp <https://git.reviewboard.kde.org/r/120029/#comment45872> typo in "after" autotests/fallbackpackagetest.cpp <https://git.reviewboard.kde.org/r/120029/#comment45873> and another typo (tiume) src/plasma/package.cpp <https://git.reviewboard.kde.org/r/120029/#comment45876> I dont' get how this const compiles, it clearly isn't. - David Edmundson On Sept. 1, 2014, 2:32 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120029/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 2:32 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > introduces the concept of fallback for packages. > this will replace the private statically linked class LookAndFeelAccess in > workspace and desktop, but be more generic so will be usable for things like > the shell package as well. > The feature has an autotest as well to check it's actually working and > doesn't break other stuff. > > the package structures that will use this, will just set a package in their > structure::initPackage() > tough for the user of Package in c++ is possible as well to set the fallback > package outside the structure if custm things are neede (it's guarded that > cycles don't occur in the fallback chain) > > > Diffs > ----- > > autotests/CMakeLists.txt 4e64f38 > autotests/data/testfallbackpackage/contents/ui/main.qml PRE-CREATION > autotests/data/testfallbackpackage/metadata.desktop PRE-CREATION > autotests/data/testpackage/contents/ui/otherfile.qml PRE-CREATION > autotests/fallbackpackagetest.h PRE-CREATION > autotests/fallbackpackagetest.cpp PRE-CREATION > src/plasma/data/servicetypes/plasma-shell.desktop e2c83ba > src/plasma/package.h 2c686d7 > src/plasma/package.cpp 6ad3321 > src/plasma/private/package_p.h d902eb1 > > Diff: https://git.reviewboard.kde.org/r/120029/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel