> On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so > setFallbackPackage follows the same pattern as addFileDefinition(), > setRequired() and the likes. > > so, for the packages of type Plasma/LookAndFeel it would be > org.kde.breeze.desktop > for packages of types Plasma/Shell, it would be org.kde.desktop > > even tough at some point it will probably have to be something more > complicated, like the default lookandfeel one depending from the current > shell, if ever needed, will be feasible. > > David Edmundson wrote: > Ah, makes sense. Thanks. > > Do you really expect a linked link big enough to cycle? I can't really > see it going 3 deep. The cycle check is call cool though :) > > Could you add a warning in setFallbackPackage() if it finds a cycle and > no-ops. Could be confusing to debug otherwise.
added warning.. i see it very unlikely that it's going to go deep, but better safe than sorry :p - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/#review65648 ----------------------------------------------------------- On Sept. 1, 2014, 6:37 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120029/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 6:37 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > introduces the concept of fallback for packages. > this will replace the private statically linked class LookAndFeelAccess in > workspace and desktop, but be more generic so will be usable for things like > the shell package as well. > The feature has an autotest as well to check it's actually working and > doesn't break other stuff. > > the package structures that will use this, will just set a package in their > structure::initPackage() > tough for the user of Package in c++ is possible as well to set the fallback > package outside the structure if custm things are neede (it's guarded that > cycles don't occur in the fallback chain) > > > Diffs > ----- > > autotests/CMakeLists.txt 4e64f38 > autotests/data/testfallbackpackage/contents/ui/main.qml PRE-CREATION > autotests/data/testfallbackpackage/metadata.desktop PRE-CREATION > autotests/data/testpackage/contents/ui/otherfile.qml PRE-CREATION > autotests/fallbackpackagetest.h PRE-CREATION > autotests/fallbackpackagetest.cpp PRE-CREATION > src/plasma/data/servicetypes/plasma-shell.desktop e2c83ba > src/plasma/package.h 2c686d7 > src/plasma/package.cpp 6ad3321 > src/plasma/private/package_p.h d902eb1 > > Diff: https://git.reviewboard.kde.org/r/120029/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
