----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/ -----------------------------------------------------------
(Updated Juli 28, 2015, 5:57 nachm.) Review request for Plasma, KDE Usability and Vishesh Handa. Changes ------- Show history when opening KRunner (whenever no query is typed in) instead of a ComboBox, as suggested by the Usability team. It has the following advantages: - No conflicting arrow key vs tab navigation with two vertically scrolling lists (results and combobox) - You can see the history immediately - You can click the history immediately - Using arrows to navigate the history like you would with results Bugs: 335731 https://bugs.kde.org/show_bug.cgi?id=335731 Repository: plasma-workspace Description ------- This turns KRunner's TextField into an editable ComboBox to provide a history. When a result is invoked, the query string is prepended to the history, query strings are only added once. ComboBox provides letter-by-letter auto completion. Diffs (updated) ----- krunner/view.h 45f4d28 krunner/view.cpp 208c88c lookandfeel/contents/runcommand/RunCommand.qml 4c6eb30 Diff: https://git.reviewboard.kde.org/r/123888/diff/ Testing ------- Somehow I have a feeling it doesn't always save the history or nukes it at times. It also has some shortcomings due to ComboBox: 1.) You cannot use the arrow keys to cycle between entries (when the popup's not opened) because arrow keys navigate through results 2.) forceActiveFocus() on the ComboBox will not activate the embedded TextField - when you had opened the popup there's a slight chance the input field won't get focussed I'll prepare a Qt patch for this. 3.) Before Qt 5.4.2 (not sure if my patch ended up in 5.4.1) pressing space in the edit combobox will open the popup, not insert a space (nasty show stopper) 4.) Plasma's edtiable ComboBox looks a bit strange imho 5.) Plasma's editable ComboBox doesn't support clearButtonShown 6.) Plasma's ComboBox has strange bullets and margins in it, that's probably a bug in Plasma Style (need to look what Desktop style does differently from us) 7.) ComboBox doesn't have a cursorPosition, I'll prepare a Qt patch for this. File Attachments (updated) ---------------- History popup https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/7ad7e5eb-4874-4f9f-9796-738fa2ac9ed5__krunnerhistory.png Auto completion https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/18714844-ef28-4cdd-af00-e6685caece9b__krunnerautocompletion.png History popup (new) https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/ad685fde-7d37-48c6-8b01-ac938a450618__krunnerhistory2.png Thanks, Kai Uwe Broulik
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel