----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review88512 -----------------------------------------------------------
plasmacalendarintegration/HolidaysConfig.qml (line 62) <https://git.reviewboard.kde.org/r/125862/#comment60695> I think we should at one point make a kqc component from this plasmacalendarintegration/HolidaysConfig.qml (line 70) <https://git.reviewboard.kde.org/r/125862/#comment60696> There's no Connections {} actually using this signal. See the timezone table plasmacalendarintegration/holidaysevents.cpp (line 45) <https://git.reviewboard.kde.org/r/125862/#comment60693> Please m_regions.clear() afterwards I've seen various Plasma crashes on teardown becasue we qDeleteAll'd without clearing. plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp (line 37) <https://git.reviewboard.kde.org/r/125862/#comment60694> Add context this - Kai Uwe Broulik On Nov. 18, 2015, 12:33 vorm., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125862/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 12:33 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This is very simple for now as there is no configuration > yet, so it just takes the default region (your locale) > and shows holidays from that. > > Obviously this needs a config to set up which regions > you want to show in there, but this is a start. > > > Diffs > ----- > > CMakeLists.txt 4783a78 > plasmacalendarintegration/CMakeLists.txt PRE-CREATION > plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION > plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION > plasmacalendarintegration/holidaysevents.h PRE-CREATION > plasmacalendarintegration/holidaysevents.cpp PRE-CREATION > plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h > PRE-CREATION > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp > PRE-CREATION > plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125862/diff/ > > > Testing > ------- > > Holidays are properly listed in calendar applet. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
