> On Nov. 18, 2015, 9:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > <https://git.reviewboard.kde.org/r/125862/diff/2/?file=417230#file417230line37> > > > > Add context this > > Martin Klapetek wrote: > Isn't "this" caputred implicitly?
no, but it is captured by "=" If it wasn't you'd have had a compile error. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review88512 ----------------------------------------------------------- On Nov. 18, 2015, 12:33 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125862/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 12:33 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This is very simple for now as there is no configuration > yet, so it just takes the default region (your locale) > and shows holidays from that. > > Obviously this needs a config to set up which regions > you want to show in there, but this is a start. > > > Diffs > ----- > > CMakeLists.txt 4783a78 > plasmacalendarintegration/CMakeLists.txt PRE-CREATION > plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION > plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION > plasmacalendarintegration/holidaysevents.h PRE-CREATION > plasmacalendarintegration/holidaysevents.cpp PRE-CREATION > plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h > PRE-CREATION > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp > PRE-CREATION > plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125862/diff/ > > > Testing > ------- > > Holidays are properly listed in calendar applet. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
