----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review94747 -----------------------------------------------------------
I think we should start adding autotests to those classes we can actually test, like this one. Could you add a simple test, so that we can at least tell the next person to expand also the autotest? - Sebastian Kügler On April 21, 2016, 10:11 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127702/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 10:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The > source property will be empty for KCM pages. > This fixes correctly returning empty source for KCM pages. Also return the > same value from get(). > > > Diffs > ----- > > src/plasmaquick/configmodel.cpp 3f69073 > > Diff: https://git.reviewboard.kde.org/r/127702/diff/ > > > Testing > ------- > > Added qml config page to plasma-pa, KCM page now works fine. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
