> On April 29, 2016, 9:51 a.m., Marco Martin wrote: > > any news on this?
Sorry, not much time now. But I did take a look and the test will need AppletInterface to actually test this case, so I think it won't be easy from plasma-framework. With the plasmashell testing subsystem added recently, it would be easier. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review95007 ----------------------------------------------------------- On April 21, 2016, 10:11 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127702/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 10:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The > source property will be empty for KCM pages. > This fixes correctly returning empty source for KCM pages. Also return the > same value from get(). > > > Diffs > ----- > > src/plasmaquick/configmodel.cpp 3f69073 > > Diff: https://git.reviewboard.kde.org/r/127702/diff/ > > > Testing > ------- > > Added qml config page to plasma-pa, KCM page now works fine. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
