----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128915/#review99195 -----------------------------------------------------------
Fix it, then Ship it! src/plasmaquick/containmentview.cpp (line 137) <https://git.reviewboard.kde.org/r/128915/#comment66781> does it render this redundant? src/plasmaquick/containmentview.cpp (line 140) <https://git.reviewboard.kde.org/r/128915/#comment66782> this if isn't very useful now. If it was null, we'd have crashed already. - David Edmundson On Sept. 15, 2016, 9:20 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128915/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 9:20 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > when the view is in SizeRootObjectToView mode, the root object is resized in > the event handler, that is too late at startup. > resize the root object right after having announced the new containment, so > the view subclass can have the view resized to the proper size beforehand, > removing an useless containment graphicsobject resize. > > > Diffs > ----- > > src/plasmaquick/containmentview.cpp 8517099 > > Diff: https://git.reviewboard.kde.org/r/128915/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
