davidedmundson added inline comments.
INLINE COMMENTS
> connection.h:49
> + Q_CLASSINFO("D-Bus Interface", "org.kde.KWin.InputDeviceManager")
> + Q_PROPERTY(QStringList devicesSysNames READ devicesSysNames CONSTANT)
> public:
This isn't constant.
Connection::processEvents() will update m_devices
Rather than add a notify on here, common practice is generally to have a :
q_signals:
deviceAdded(QDBusObjectPath pathOfNewlyAddedObject)
deviceRemoved(QDBusObjectPath oldPath) or some UUID
(remember to export the signals as well if you add them)
that way the KCM can avoid reparsing the list and work out what's changed.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3479
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, #kwin, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas
