davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> connection.cpp:159
> QStringLiteral("notifyChange"),
> this, SLOT(slotKGlobalSettingsNotifyChange(int,int)));
> -
> - QDBusConnection::sessionBus().registerService(s_serviceName);
> +
> QDBusConnection::sessionBus().registerObject(QStringLiteral("/org/kde/KWin/InputDeviceManager"),
> +
> QStringLiteral("org.kde.KWin.InputDeviceManager"),
only other comment I did have
We have the path
/org/kde/KWin/InputDevice/event0
/org/kde/KWin/InputDevice/event1
...
I would put the manager interface on the path
/org/kde/KWin/InputDevice
so it reads like a tree.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3479
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #kwin, #plasma, davidedmundson
Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas
