davidedmundson added inline comments.
INLINE COMMENTS
> statusnotifieritemsource.cpp:472
> if (m_statusNotifierItemInterface &&
> m_statusNotifierItemInterface->isValid()) {
> - m_statusNotifierItemInterface->call(QDBus::NoBlock,
> QStringLiteral("Activate"), x, y);
> + m_statusNotifierItemInterface->call(QDBus::BlockWithGui,
> QStringLiteral("Activate"), x, y);
> + return m_statusNotifierItemInterface->lastError().isValid();
we could just move the the calling ContextMenu on failure logic into the C++
It saves this blocking, fixes the bug for all SNI datasource users, and allows
us to act differently depending on what the DBus error actually is
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4301
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, davidedmundson
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
