apol added inline comments.
INLINE COMMENTS
> KNSBackend.cpp:111
> // Setting setFetching to false when we get an error ensures we don't
> end up in an eternally-fetching state
> - connect(m_engine, &KNSCore::Engine::signalError, this, [this](const
> QString &error) { this->setFetching(false); qWarning() << "kns error" <<
> objectName() << error; });
> + connect(m_engine, &KNSCore::Engine::signalError, this, [this](const
> QString &error) {
> + if(error == QLatin1Literal("All categories are missing")) {
Could be moved into a proper slot?
> KNSBackend.cpp:200
> }
> -// qDebug() << "received" << this << m_page << m_resourcesByName.count();
> +// qDebug() << "received" << objectName() << this << m_page <<
> m_resourcesByName.count();
> if (!m_responsePending) {
Unrelated change
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5147
To: leinir, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
