leinir closed this revision.
leinir added a comment.

  Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7

INLINE COMMENTS

> apol wrote in KNSBackend.cpp:111
> Could be moved into a proper slot?

It /is/ starting to be more than trivial code in there, that'd make sense, 
yeah. i'm sure this won't be the last time changes happen to the kns error 
handling code, i'll move it into a proper slot next time 'round :)

> apol wrote in KNSBackend.cpp:200
> Unrelated change

Ah, yes, so it is! Was tracking where things were breaking and whatnot, and 
thought it'd probably be useful to keep that modification for future similar 
tracking of things :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5147

To: leinir, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to