davidedmundson added a comment.

  edit. 3 things.

INLINE COMMENTS

> notificationsengine.cpp:419
>          removeSource(source);
>          emit NotificationClosed(id, closeReason);
>      }

We need to be careful to not emit this twice. 
That would be a protocol error.

I think we'll have emitted it when the first one timed out.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7256

To: progwolff, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

Reply via email to