hpereiradacosta added a comment.

  last round of modifications: simplifications of the blurHelper class. 
  Also, for the config ui, maybe it makes more sense to call the "Transparency" 
tab, only "Menus" and change "Menu:" into "Transparency:"
  Unless of course one wants to add transparency behind other widgets.
  Then I think it is good to go.


> breezeblurhelper.h:138
> +
> +#endif

Because the use of this class is much simplified wrt the original one, it can 
be significantly simplified:

_timer (and timerEvent) are unnecessary.
Then update() could be removed, as well as _widgets, as well as the 
widgetDestroyed callback.
Then update(widget) could be called directly in the event filter.

  R31 Breeze


To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

Reply via email to