hpereiradacosta added a comment.

  In https://phabricator.kde.org/D10170#199153, @anemeth wrote:
  
  > Now only enabled blur when the frame is transparent.
  >
  > @hpereiradacosta
  >  drawPanelMenuPrimitive only runs once per panel creation and not 60 times 
per second, right?
  
  
  Well it is also probably called every time the selected (on mouse-over) item 
changes. So basically everytime you move the mouse in the list. 
  Now setting the property only once per menu (or rather, only at creation or 
when its sizes change), would require quite a bit more machinery. Probably 
something like a "breezeblurhelper" to which you would need to register the 
menu at creation (in ::polish) and then deal with resizeevent and configuration 
changes inside there.  
  Unless you feel like giving it a shot yourself, I could probably take care of 
that when this code is committed.
  There was some code of this kind (more complex though), in the now 
decommissioned oxygen-transparent code. That was called oxygenblurhelper.
  
  > This is what enabled blur behind a window: 
https://github.com/KDE/kwindowsystem/blob/master/src/platforms/xcb/kwindoweffects.cpp#L245
  >  I don't think it checks if it's already enabled.
  >  But if it's called only once per panel then it's not an issue.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10170

To: anemeth, hpereiradacosta, #plasma, colomar, alake
Cc: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, 
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

Reply via email to